feat: allow to set ansible base dir project wide#422
Open
hatch01 wants to merge 1 commit intorundeck-plugins:mainfrom
Open
feat: allow to set ansible base dir project wide#422hatch01 wants to merge 1 commit intorundeck-plugins:mainfrom
hatch01 wants to merge 1 commit intorundeck-plugins:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to configure the Ansible base directory at the project or framework level, addressing issue #271. Previously, the base directory could only be set at the job level, requiring users to configure it individually for each job or use workarounds like symbolic links to access required files such as group_vars.
- Extends all Ansible plugin configurations to support project-wide and framework-wide base directory settings
- Updates the property resolution logic to check project and framework configurations
- Adds documentation for the new configuration option
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AnsiblePlaybookWorkflowStep.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsiblePlaybookWorflowNodeStep.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsiblePlaybookInlineWorkflowStep.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsiblePlaybookInlineWorkflowNodeStep.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsibleNodeExecutor.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsibleModuleWorkflowStep.java | Adds project and framework mappings for ansible-base-dir-path to enable project-wide configuration |
| AnsibleRunnerContextBuilder.java | Updates getBaseDir() to use PropertyResolver for hierarchical property resolution (job → node → project → framework) |
| README.md | Documents the new ansible-base-dir-path configuration option and its project-wide usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to set the Ansible base directory at the project level.
This is very useful in this case, for example, where.
For each project, I have a repo with playbooks and the rundeck jobs.
So the base dir is always the path to the scmImport folder.
Closes #271
Tests :
I created a basic project
Set the value project-wide and see it used in the jobs.
Set the value also at the job level and confirm the value is used instead of the project one.