feat/multisig support - #65
Conversation
a5e12aa to
f509db6
Compare
ef2aa60 to
e6fc863
Compare
raphjaph
left a comment
raphjaph
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nits
| &[P2WSH_2OF2_PRIVATE_KEY_1, WIF_PRIVATE_KEY], | ||
| Some(P2WSH_2OF2_WITNESS_SCRIPT), | ||
| ) | ||
| .is_err()); |
There was a problem hiding this comment.
Maybe assert the exact error type since we have them
|
|
||
| #[allow(clippy::result_large_err)] | ||
| pub fn parse_multisig(script: &bitcoin::Script) -> Result<(usize, Vec<PublicKey>)> { | ||
| use bitcoin::script::Instruction; |
There was a problem hiding this comment.
Put all import statements either at top of file or in src/lib.rs
|
I just merged #79 to update the MSRV to 1.74, following what rust-bitcoin has. If you @aagbotemi update this branch the CI should pass. I'll also try and have a look at your other PRs during this week. @johnzilla will also look at yours |
e6fc863 to
1657fa8
Compare
Thank you for the review, and I've updated the PR.
I'll be looking forward to it. |
2 participants
Summary
Add multisig support to BIP-322 message signing and verification.
Changes
sign_simple_encodedandsign_full_encodedto acceptwif_private_keys: &[impl AsRef<str>]andwitness_script_hex: Option<&str>instead of a single WIF keycreate_message_signature_p2wshfor P2WSH multisig witness constructioncreate_message_signature_p2sh_multisigfor P2SH multisig script_sig constructionverify_full_p2wshfor P2WSH and P2SH-P2WSH multisig verification.verify_full_p2sh_multisigfor legacy P2SH multisig script_sig verificationparse_multisigto decode m-of-n parameters and public keysNoPrivateKeyserror variantsCloses #25