Implement verification states, time locks and required consensus rules - #73
Open
aagbotemi wants to merge 15 commits into
Open
Implement verification states, time locks and required consensus rules#73aagbotemi wants to merge 15 commits into
aagbotemi wants to merge 15 commits into
Conversation
aagbotemi
force-pushed
the
feat/verification-states
branch
from
July 24, 2026 12:53
941a207 to
b3d5c8c
Compare
aagbotemi
force-pushed
the
feat/verification-states
branch
from
July 27, 2026 09:03
b3d5c8c to
a186d35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the spec's three-state verifier output, time lock support for full signatures, explicit enforcement of the required consensus rules, and spec-compliant prevout resolution for proof of funds.
Rebased on #71
Changes
Verificationenum (Valid { time, age }/Inconclusive).InputVerificationfor per-input outcomes.LockParamsto setnLockTimeandnSequenceonto_sign.verify_*functions now returnResult<Verification>, with the invalid state reported asErr.Notes for reviewers
Inconclusiverather than erroring.LockParamsversion is derived — 2 when any lock is set, else 0, so an inconsistent version can't be constructed. Threaded throughsign_full,sign_full_encoded,sign_pof,sign_pof_encodedandcreate_to_sign. The simple variant keeps all-zero locks per the spec.Closes #72