Expose raw key-value pairs on v2 Map types#103
Open
macgyver13 wants to merge 3 commits intorust-bitcoin:masterfrom
Open
Expose raw key-value pairs on v2 Map types#103macgyver13 wants to merge 3 commits intorust-bitcoin:masterfrom
macgyver13 wants to merge 3 commits intorust-bitcoin:masterfrom
Conversation
Downstream code needs a method to iterate all fields of a PSBT map as raw (type, key, value) tuples. Allows an extension trait to expose pairs without duplicating field knowledge.
macgyver13
force-pushed
the
add-pairs-v2-map
branch
from
c875132 to
11f50e2
Compare
Member
|
Thanks for the contribution @macgyver13, we just migrated this repository to https://gitea.bitcoin.ninja/rust-bitcoin/rust-psbt. There will be some teething problems so please be patient with us for a bit. This repo and secp are test repos to see how the new git hosting will work for rust-bitcoin projects. (This message was posted after the migration and will not appear over there.) |
Contributor
Author
|
I discovered the Migration Marker issue this morning. Happy to help you test out either or both systems via this PR, just let me know. |
Member
|
Cheers, I reviewed/acked over there. |
macgyver13
pushed a commit
to macgyver13/rust-psbt
that referenced
this pull request
Apr 13, 2026
11f50e2 test: add failing tests for pairs() (macgyver13) 695c8c4 feat: expose raw key-value pairs on v2 map types (macgyver13) aaf4320 docs: fix typo in PSBT_OUT_PROPRIETARY comment (macgyver13) Pull request description: Provides downstream consumers a way iterate all fields of a PSBT map. Without this consumers must duplicate field mapping for each Map. Also fixes a small doc typo. ACKs for top commit: tobin: ACK 11f50e2 Tree-SHA512: 4a208c362a21369aa48bbfceac59b0a4d41604c1530cc06e0866d76ea5b9489680f68365b72573094d0f4e9d0616a03cf3d5bd6b65b6efdeb7bb77e3ffee813b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides downstream consumers a way iterate all fields of a PSBT map. Without this consumers must duplicate field mapping for each Map.
Also fixes a small doc typo.