Bump secp256k1-sys to v0.13.0 #879
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement fixes for breaking changes in upstream libsecp256k1 library, first bump it to its latest released version. Ran script with ./vendor-libsecp.sh -f v0.7.0
This change was introduced to unset SECP256K1_API variable and allow the management of symbol visibility through rust-cc. But its effect rather than unset the variable was setting it to an empty value, missing the intended behavior, and in the latest release, disabling the defaults used for the library to link symbols right. Also, the latest libsecp256k1 release, v0.7.0, introduces a change that allows the control of the visibility of certain symbols through the `-fvisibility=<value` flag, allowing the change of visibility without having to fiddle with SECP256K1_API variable.
Member
|
Can you update the lockfiles along with this version bump? You can run Or you can explicitly run cp Cargo-minimal.lock Cargo.lock
cargo check # this updates the lockfile immediately, so you can Ctrl+C it once it starts
cp Cargo.lock Cargo-minimal.lock
cp Cargo-recent.lock Cargo.lock
cargo check
cp Cargo.lock Cargo-recent.lockwhich is the same as what the contrib script does, it's just that I habitually do this so much that I never remember the contrib script is there.. |
Executed `just ulf`. Candidate to squash with dab3f76.
Member
|
Needs a changelog entry please @nymius. Do we want to cut a |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bump the version of the secp256k1-sys internal crate to version 0.13.0.
It includes all the changes from libsecp256k1 at v0.7.0 and a possible fix for the linking issues related to the change the pointers
secp256k1_context_staticandsecp256k1_context_no_precomptoconstpointers.Fixes #878