Add EABI C examples#176
Open
jonathanpallant wants to merge 7 commits into
Open
Conversation
This does a very basic EABI check. We don't examine all the details, but it's enough to see whether we agree on short-enums, or the hard-float ABI. CI updated to install GCC (for cc-rs) and libclang1 (for bindgen). cc-rs doesn't currently support all our targets, so this will fail.
It requires a C compiler and most CI jobs don't have one.
Contributor
Author
|
Updated to use a fork of cc-rs at https://github.com/jonathanpallant/cc-rs/tree/add-more-bare-metal-arm, with a bunch of fixes for these targets. The upstream PR is at rust-lang/cc-rs#1753. |
Contributor
Author
|
cc-rs had a release containing my patches |
Contributor
Author
|
I drafted this to prompt me to add the extra tests, but actually these tests are better than no tests so I'm undrafting this so we can merge it. I'll make an issue to add more tests later. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to check Rust/C interop (but only as a basic smoke test).
It looks like cc-rs needs updating to understand all these targets, as you get errors about "this architecture doesn't have an FPU" where cc-rs failed to add an-mfpu=blahoption automatically.My fix for cc-rs was merged and released.
See #185 for additional tests we might want to add later.