NOT READY FOR REVIEW: feat(toml): allow overriding inherited default-features in 2024#17126
Draft
0xPoe wants to merge 4 commits into
Draft
NOT READY FOR REVIEW: feat(toml): allow overriding inherited default-features in 2024#171260xPoe wants to merge 4 commits into
0xPoe wants to merge 4 commits into
Conversation
Impl RFC 3945, on Edition 2024+ allow workspace members to override the workspace dependency's `default-features` setting. Earlier editions are unchanged: setting `default-features` on an inherited dependency is still ignored with a warning. Signed-off-by: 0xPoe <techregister@pm.me>
Signed-off-by: 0xPoe <techregister@pm.me>
`cargo add --no-default-features` (or `--default-features`) against a dependency inherited from `[workspace.dependencies]` is now allowed when the package is on Edition 2024+, matching the manifest behavior. Earlier editions still error, pointing the user to the workspace manifest. Signed-off-by: 0xPoe <techregister@pm.me>
Signed-off-by: 0xPoe <techregister@pm.me>
rustbot
added
A-documenting-cargo-itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
close #16959
Implement RFC 3945, on Edition 2024+ allow workspace members to override the workspace dependency's
default-featuressetting.Earlier editions are unchanged: setting
default-featureson an inherited dependency is still ignored with a warning.Also, this change would allow
cargo add X --no-default-features -p Y, but only on Edition 2024+.How to test and review this PR?
Review and check it commit by commit.
r?@ghost