unix: add preadv2 and pwritev2 to android and linux#5157
Open
Elie-Kh wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in an Android module cc @maurer |
Elie-Kh
force-pushed
the
linux-preadwritev2
branch
from
ec99a98 to
fe75a48
Compare
This comment has been minimized.
This comment has been minimized.
Elie-Kh
changed the title
Member
|
Seems you messed up the commits in the branch, could you fix it to have exact one commit? |
Author
|
Sure thing, it's been a minute since I've worked with github, let me fix that |
Elie-Kh
force-pushed
the
linux-preadwritev2
branch
from
5ce60e5 to
0257c2a
Compare
Author
|
And that should have it fixed! |
Elie-Kh
force-pushed
the
linux-preadwritev2
branch
from
0257c2a to
3c6d867
Compare
This comment has been minimized.
This comment has been minimized.
Elie-Kh
force-pushed
the
linux-preadwritev2
branch
from
3c6d867 to
b55b402
Compare
This comment has been minimized.
This comment has been minimized.
Elie-Kh
force-pushed
the
linux-preadwritev2
branch
from
b55b402 to
d158103
Compare
This comment has been minimized.
This comment has been minimized.
Add preadv2 and pwrite2 to linux and Android, to allow using the new flags introduced in rust-lang#4452. Add flags to Android too Move definitions from musl and gnu to linux/mod.rs instead of each separate system alone. Skip test on Android due to the definitions being introduced in API 33
JohnTitor
force-pushed
the
linux-preadwritev2
branch
from
d158103 to
1d61311
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
Seems you need some more ignores: https://github.com/rust-lang/libc/actions/runs/27483200559/job/81234642626?pr=5157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add preadv2 and pwrite2 to linux and Android, making majority of linux_like based systems have support, to allow using the new flags introduced in #4452. Move definitions to linux_like/mod.rs instead of each separate system alone.
libc-test/semverhave been updated - no tests to modify*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
Getting error while testing locally due to different linux version and mismatch of SW_MAX and MS_NOUSER. Modifying those to match local system (0x11 and 0x80000000) shows passing tests using
cargo test.Unable to test other systems, need to run CI