refactor: deprecate lfs64 bindings in linux musl#5170
Open
dybucc wants to merge 1 commit into
Open
Conversation
These types are defined upstream in terms of their unsuffixed types, and a large part of the surface API in the exposed bindings does the same. The `libc` crate is moving towards providing unsuffixed types and routines that avoid the need for aliases. This intent was expressed on Windows platforms in rust-lang#5032. This patch altogether deprecates all items under Linux musl that are conditionally exposed upstream under the `_LARGEFILE64_SOURCE` feature test macro.
dybucc
force-pushed
the
musl-off_t-deprecation
branch
from
911a9e2 to
348a55e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes support for the exposed LFS64 bindings under Linux musl. This follows from the
libccrate's attempts at providing a single, unsuffixed type with which to provide 64-bit functionality.This follows from #5032, where I understood
libcwas meant to provide a single, unsuffixed type and not necessarily support aliases (much less conditional aliases.) Upstream musl also defines the LFS64 types routines in terms of the unsuffixed types and routines.This patch ensures we deprecate these types and the whole
musl/lfs64module in favor of using only the unsuffixed types and routines.Sources
No specific sources are provided. Running the following command with
rgin the main worktree of latest musl should yield search results that show the uniform aliasing mentioned above across all header files.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI