Update export_name to use the attribute template#1902
Open
ehuss wants to merge 11 commits intorust-lang:masterfrom
Open
Update export_name to use the attribute template#1902ehuss wants to merge 11 commits intorust-lang:masterfrom
export_name to use the attribute template#1902ehuss wants to merge 11 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Specifies the interaction with export_name and no_mangle. This is essentially a duplicate of abi.no_mangle.export_name, but I think it is worthwile to say it in both places.
I'm not sure why this wasn't added before with no_mangle. I believe this is done here: https://github.com/rust-lang/rust/blob/HEAD/compiler/rustc_passes/src/dead.rs#L690-L700
I'm guessing this is a reasonable rule to have for all targets. At least rustc treats it that way. https://github.com/rust-lang/rust/blob/5d707b07e42766c080c5012869c9988a18dcbb83/compiler/rustc_codegen_ssa/src/codegen_attrs.rs#L254-L264
More closely align with the template, and some minor word tweaks.
| > `rustc` currently ignores `export_name` in some positions, but this may be rejected in the future. | ||
|
|
||
| r[abi.export_name.duplicates] | ||
| Only the last use of `export_name` on an item has effect. |
There was a problem hiding this comment.
This was changed by rust-lang/rust#153041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rules:
abi.export_name.allowed-positionsabi.export_name.duplicatesabi.export_name.no_mangleabi.export_name.publicly-exportedabi.export_name.nullabi.export_name.generic