internal: migrate generate_delegate_trait to SyntaxEditor api
#21199
+451
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Young-Flash
force-pushed
the
migrate_generate_delegate_trait
branch
from
5e796b9 to
d10843a
Compare
Young-Flash
force-pushed
the
migrate_generate_delegate_trait
branch
from
d10843a to
1a5d1bf
Compare
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
reviewed
Dec 5, 2025
| @@ -254,51 +256,47 @@ fn generate_impl( | |||
| delegee: &Delegee, | |||
| edition: Edition, | |||
| ) -> Option<ast::Impl> { | |||
| let make = SyntaxFactory::without_mappings(); | |||
Member
There was a problem hiding this comment.
Don't we need mapping here?
Member
Author
There was a problem hiding this comment.
This assist generates entirely new code (a new impl block) rather than editing existing syntax. Mappings are needed when using SourceChangeBuilder::make_editor() to edit existing syntax trees, where we need to track the relationship between original and new nodes for features like snippet placeholders. Since we're doing pure code generation, the mapping overhead is unnecessary.
Here is my understanding, is that right?
Member
There was a problem hiding this comment.
Yeah, that's correct but given the long body of this assist, I'd prefer having a comment for that 😄
ShoyuVanilla
approved these changes
Dec 8, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes for this migration are a bit more extensive than before, as some method calls indirectly use
ted::*apipart of #18285