Add unused_async_trait_impl lint #16244
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wassasin
force-pushed
the
unused_async_trait_impl
branch
from
3bce957 to
07c84ff
Compare
Wassasin
force-pushed
the
unused_async_trait_impl
branch
from
07c84ff to
29282db
Compare
Collaborator
|
☔ The latest upstream changes (possibly 741b684) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unused_async_trait_impl]: added lint that checks for trait impl functions that are unnecessarilyasync. By rewriting them to return acore::future::readyan unnecessary coroutine is prevented.In an embedded context having many trivial async blocks potentially hurts code size significantly. This lint enables projects to quickly find the cases that this applies to.
Unsure about if this is the right method to replace the relevant code spans. Any feedback is very welcome.