Skip to content

In BTreeMap::eq, do not compare the elements if the sizes are different. #149125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Dec 2, 2025
+98 −1
Merged

In BTreeMap::eq, do not compare the elements if the sizes are different. #149125

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4adcdbb
In `BTreeMap::eq`, do not compare the elements if the sizes are diffe…
zachs18 Nov 20, 2025
907f5c1
Add regression test for collections' PartialEq::eq impls not comparin…
zachs18 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/alloc/src/collections/btree/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2416,7 +2416,7 @@ impl<K, V> Default for BTreeMap<K, V> {
#[stable(feature = "rust1", since = "1.0.0")]
impl<K: PartialEq, V: PartialEq, A: Allocator + Clone> PartialEq for BTreeMap<K, V, A> {
fn eq(&self, other: &BTreeMap<K, V, A>) -> bool {
self.iter().eq(other)
self.len() == other.len() && self.iter().zip(other).all(|(a, b)| a == b)
}
}

Expand Down
Loading