Skip to content

std: sys: net: uefi: Make TcpStream Send #150990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Jan 13, 2026
Merged

std: sys: net: uefi: Make TcpStream Send #150990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions library/std/src/sys/net/connection/uefi/tcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ pub(crate) enum Tcp {
V4(tcp4::Tcp4),
}

// SAFETY: UEFI has no threads.
unsafe impl Send for Tcp {}
Copy link
Copy Markdown
Member

@RalfJung RalfJung Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UEFI still has signal handlers / interrupts though, doesn't it? Those are basically a form of concurrency, so Send isn't "free".

Also see Zulip.

Copy link
Copy Markdown
Member

@RalfJung RalfJung Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#154357 updates the comment for this impl.


impl Tcp {
pub(crate) fn connect(addr: &SocketAddr, timeout: Option<Duration>) -> io::Result<Self> {
match addr {
Expand Down
Loading