Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions compiler/rustc_llvm/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,16 @@ fn main() {
continue;
}

// On apple-darwin, llvm-config reports the versioned shared library name such as LLVM-22-..., but
// the distributed toolchain ships libLLVM.dylib. Normalize the link name here.
let name =
if target.contains("apple-darwin") && llvm_kind == "dylib" && name.starts_with("LLVM-")
{
"LLVM"
} else {
name
};

let kind = if name.starts_with("LLVM") {
llvm_kind
} else if is_static {
Expand Down
10 changes: 7 additions & 3 deletions compiler/rustc_metadata/src/native_libs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,15 @@ pub fn walk_native_lib_search_dirs<R>(
f(&sess.target_tlib_path.dir.join("self-contained"), false)?;
}

let has_shared_llvm_apple_darwin =
sess.target.is_like_darwin && sess.target_tlib_path.dir.join("libLLVM.dylib").exists();

// Toolchains for some targets may ship `libunwind.a`, but place it into the main sysroot
// library directory instead of the self-contained directories.
// Sanitizer libraries have the same issue and are also linked by name on Apple targets.
// The targets here should be in sync with `copy_third_party_objects` in bootstrap.
// Finally there is shared LLVM library, which unlike compiler libraries, is linked by the name,
// therefore requiring the search path for the linker.
// On Apple targets, shared LLVM is linked by name, so when `libLLVM.dylib` is
// present in the target libdir, add that directory to the linker search path.
// FIXME: implement `-Clink-self-contained=+/-unwind,+/-sanitizers`, move the shipped libunwind
// and sanitizers to self-contained directory, and stop adding this search path.
// FIXME: On AIX this also has the side-effect of making the list of library search paths
Expand All @@ -77,7 +80,8 @@ pub fn walk_native_lib_search_dirs<R>(
|| sess.target.os == Os::Linux
|| sess.target.os == Os::Fuchsia
|| sess.target.is_like_aix
|| sess.target.is_like_darwin && !sess.sanitizers().is_empty()
|| sess.target.is_like_darwin
&& (!sess.sanitizers().is_empty() || has_shared_llvm_apple_darwin)
|| sess.target.os == Os::Windows
&& sess.target.env == Env::Gnu
&& sess.target.abi == Abi::Llvm
Expand Down
1 change: 1 addition & 0 deletions src/ci/github-actions/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ auto:
--enable-sanitizers
--enable-profiler
--set rust.jemalloc
--set llvm.link-shared=true
--set rust.lto=thin
--set rust.codegen-units=1
# Aarch64 tooling only needs to support macOS 11.0 and up as nothing else
Expand Down
Loading