Open
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
find-param-in-clause-ambig
branch
from
3564a3f to
755953f
Compare
This comment has been minimized.
This comment has been minimized.
see the added test
lcnr
force-pushed
the
find-param-in-clause-ambig
branch
from
755953f to
a4564e7
Compare
lcnr
changed the title
FindParamInClause global on overflowFindParamInClause handle edge-cases
Collaborator
|
|
rustbot
added
S-waiting-on-review
Contributor
Author
|
r? BoxyUwU |
Collaborator
|
Requested reviewer is already assigned to this pull request. Please choose another assignee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If normalization is ambiguous, we want to treat the where-bound as non-global. The affected code should pretty much always have other errors in that case. It does make reasoning about trait solver cycles and rerunning more confusing and just feels wrong ™️ I encountered this while looking into
ml-kem(rust-lang/trait-system-refactor-initiative#246). I don't know whether this matters in practice and don't care to look into it too deeply.We also want to properly handle concrete aliases which mention to something mentioning a generic parameter due to another where-bound.
r? @BoxyUwU