Split out the creation of CycleError to a new process_cycle function#154146
Open
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Open
Split out the creation of CycleError to a new process_cycle function#154146Zoxc wants to merge 1 commit intorust-lang:mainfrom
CycleError to a new process_cycle function#154146Zoxc wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
the
A-query-system
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @nnethercote |
Contributor
|
☔ The latest upstream changes (presumably #154289) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the creation of
CycleErrorto a newprocess_cyclefunction. This makes it a bit clearer which operations are done for diagnostic purposes vs. what's needed to break cycles.