Make Ipv6Addr::multicast_scope() exhaustive#154196
Open
Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Open
Make Ipv6Addr::multicast_scope() exhaustive#154196Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Ipv6Addr::multicast_scope() exhaustive#154196Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Jules-Bertholet
force-pushed
the
ipv6-multicast-discriminant
branch
from
816bc7c to
4ea9c64
Compare
This comment has been minimized.
This comment has been minimized.
Jules-Bertholet
force-pushed
the
ipv6-multicast-discriminant
branch
from
4ea9c64 to
c34af65
Compare
And make `Ipv6MulticastScope` exhaustive, with `repr(u8)` and the proper discriminant values. The variants for the two reserved scopes are gated behind a perma-unstable feature, in order to avoid committing to names for them. [IETF RFC 4291](https://datatracker.ietf.org/doc/html/rfc4291#section-2.7) and [IETF RFC 7346](https://datatracker.ietf.org/doc/html/rfc7346#section-2) define the list of multicast scopes. The former document says: > scopes labeled "(unassigned)" are available for administrators > to define additional multicast regions.
Jules-Bertholet
force-pushed
the
ipv6-multicast-discriminant
branch
from
c34af65 to
ebb91f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make
Ipv6MulticastScopeexhaustive, withrepr(u8)and the proper discriminant values. The variants for the two reserved scopes are gated behind a perma-unstable feature, in order to avoid committing to names for them.IETF RFC 4291 and IETF RFC 7346 define the list of multicast scopes. The former document says:
Tracking issue: #27709
@rustbot label A-io