miri recursive validation: only check one layer deep#154269
Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Open
miri recursive validation: only check one layer deep#154269RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
miri recursive checking: only check one layer deep try-job: dist-x86_64-linux
RalfJung
force-pushed
the
miri-recursive-shallow
branch
from
3b4979d to
54efd74
Compare
Member
Author
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
miri recursive checking: only check one layer deep try-job: dist-x86_64-linux
RalfJung
force-pushed
the
miri-recursive-shallow
branch
from
54efd74 to
eac975c
Compare
RalfJung
changed the title
Contributor
RalfJung
force-pushed
the
miri-recursive-shallow
branch
from
eac975c to
5f68044
Compare
Collaborator
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As has been proposed in rust-lang/unsafe-code-guidelines#414, let's see what happens if we make recursive checking in Miri shallow: we treat whatever is behind a reference as if it was inside
MaybeDangling, which means nested references do not have to be dereferenceable.This changes the meaning of the original flag -- I don't think it is worth supporting multiple variants of recursive checking (it'd require a bunch of new plumbing), and this seems to be the strictest variant that still has any traction in the discussion.