Skip to content

Rollup of 7 pull requests#154312

Open
JonathanBrouwer wants to merge 17 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-V37uysi
Open

Rollup of 7 pull requests#154312
JonathanBrouwer wants to merge 17 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-V37uysi

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

theemathas and others added 17 commits December 19, 2025 11:03
Also, delete impls on non-Deref types.

Pin doesn't do anything useful for non-Deref types, so PinCoerceUnsized
on such types makes no sense.

This is a breaking change, since stable code can observe the deleted
`PinCoerceUnsized` impls by uselessly coercing between such types
inside a `Pin`.

There is still some strange behavior, such as `Pin<&mut i32>` being
able to coerce to `Pin<&dyn Send>`, but not being able to coerce to
`Pin<&i32>`. However, I don't think it's possible to fix this.

Fixes rust-lang#145081
This also fixes the Cargo rendering bug noted in the pre-release thread.
…li-obk

Make PinCoerceUnsized require Deref

Also, delete impls on non-Deref types.

Pin doesn't do anything useful for non-Deref types, so PinCoerceUnsized on such types makes no sense.

This is a breaking change, since stable code can observe the deleted `PinCoerceUnsized` impls by uselessly coercing between such types inside a `Pin`.

There is still some strange behavior, such as `Pin<&mut i32>` being able to coerce to `Pin<&dyn Send>`, but not being able to coerce to `Pin<&i32>`. However, I don't think it's possible to fix this.

Fixes rust-lang#145081
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
…-2, r=petrochenkov

Delegation: eliminate usage of AST from generics creation

This PR eliminates all interaction with AST during creation of generics, then it supports proper const param types propagation. Fixes rust-lang#153433. Fixes rust-lang#153499. Part of rust-lang#118212.

r? @petrochenkov
allow `incomplete_features` in more tests

This PR allows the `incomplete_features` lint for the `traits` and `const-generics` directories. `specialization` will come in a followup PR.

Followup to rust-lang#154174.
Part of rust-lang#154168.
doc: linker-plugin-based LTO: update list of good combinations

This PR is similar to rust-lang#146827 . I just ran the Python script as was [recommended](rust-lang#146827 (review)) in this comment. Also updated the LOWER_BOUND in the script to skip a bit redundant work in the Python script.

@nnethercote pinging you as a reviewer here since the last time you did it too ;)
Cherry-pick 1.94.1 release notes

This also fixes the Cargo rendering bug noted in the pre-release thread (https://internals.rust-lang.org/t/rust-1-94-1-pre-release-testing/24107/2).
…nathanBrouwer

Remove more `BuiltinLintDiag` variants - part 2

Part of rust-lang#153099.

r? @JonathanBrouwer
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 24, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Mar 24, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit 17d6c45 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 24, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #149218 (Make PinCoerceUnsized require Deref)
 - #154094 (add neon load/store assembly test)
 - #154142 (Delegation: eliminate usage of AST from generics creation)
 - #154276 (allow `incomplete_features` in more tests)
 - #154284 (doc: linker-plugin-based LTO: update list of good combinations)
 - #154286 (Cherry-pick 1.94.1 release notes)
 - #154303 (Remove more `BuiltinLintDiag` variants - part 2)
@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] gimli test:false 5.318
[RUSTC-TIMING] object test:false 5.383
warning: dropping unsupported crate type `dylib` for target `x86_64-fortanix-unknown-sgx`

error[E0277]: the trait bound `UserRef<T>: Deref` is not satisfied
   --> /rustc/a0f73cdc96afbd6c3aa4e611abcef2edff58f4b7/library/std/src/sys/pal/sgx/abi/usercalls/alloc.rs:777:45
    |
777 | unsafe impl<T: ?Sized> PinCoerceUnsized for UserRef<T> {}
    |                                             ^^^^^^^^^^ unsatisfied trait bound
    |
help: the trait `Deref` is not implemented for `UserRef<T>`
   --> /rustc/a0f73cdc96afbd6c3aa4e611abcef2edff58f4b7/library/std/src/sys/pal/sgx/abi/usercalls/alloc.rs:172:1
    |
172 | pub struct UserRef<T: ?Sized>(UnsafeCell<T>);
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: required by a bound in `PinCoerceUnsized`
   --> /rustc/a0f73cdc96afbd6c3aa4e611abcef2edff58f4b7/library/core/src/pin.rs:1846:0

For more information about this error, try `rustc --explain E0277`.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

💔 Test for a0f73cd failed: CI. Failed job:

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

PR #149218, which is a member of this rollup, was unapproved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants