Make rustc_hir_analysis not depend on rustc_lint.

[nnethercote]

rustc_hir_analysis depends on rustc_lint in just a single function: emit_delayed_lint, which is used by the
"emit_ast_lowering_delayed_lints" checking section within rustc_hir_analysis::check_crate.

This commit moves that function and section to out of rustc_hir_analysis::check_crate, into rustc_interface, eliminating the dependency. This seems reasonable because the delayed lint errors aren't really related to HIR analysis, they were in there just because HIR analysis is what follows AST lowering.

This means rustc_hir_analysis and rustc_lint can both start compiling as soon as rustc_trait_selection finishes. This also changes the error order in one test, which doesn't matter.

The commit also changes emit_delayed_lint to emit_delayed_lints, factoring out some code duplicated in rustdoc.

r? @davidtwco

[nnethercote]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: f563964 (f563964173ddaf1ed3e37d5d0de92ec538aa79c2, parent: 212ef7770dfad656782207fda799bdae28fc5b7b)

[rust-timer]

Finished benchmarking commit (f563964): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-6.5%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.9%	[7.9%, 7.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.064s -> 483.055s (-0.21%)
Artifact size: 396.84 MiB -> 394.95 MiB (-0.48%)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.