Skip to content

delegation: invoke hir_crate_items before force_delayed_owners_lowering#154368

Open
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
aerooneqq:delegation-force-lowering-later
Open

delegation: invoke hir_crate_items before force_delayed_owners_lowering#154368
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
aerooneqq:delegation-force-lowering-later

Conversation

@aerooneqq
Copy link
Contributor

@aerooneqq aerooneqq commented Mar 25, 2026 •
edited by rustbot
Loading

This PR forces lowering of delayed owners after hir_crate_items, as some diagnostics use hir_crate_items which results in query cycle which is then hangs calling def_path_str again and again. Fixes #154169. Part of #118212.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 25, 2026
@aerooneqq aerooneqq changed the title delegation: invoke hir_crate_items before force_delayed_lowering delegation: invoke hir_crate_items before force_delayed_owners_lowering Mar 25, 2026
@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Mar 25, 2026
@petrochenkov
Copy link
Contributor

petrochenkov commented Mar 25, 2026

What specific uses of def_path_str cause the infinite recursion?
Perhaps using something like with_reduced_queries will allow to break the recursion locally, and avoid global changes that this PR does.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

delegation: oom

3 participants

@aerooneqq @petrochenkov @rustbot