Skip linting unused braces for FunctionArg and MethodArg context for 2024 later #154373
Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Open
Skip linting unused braces for FunctionArg and MethodArg context for 2024 later #154373chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154247
unused_bracesis a AST level lint, but in Rust 2024 braces around function and method arguments can affect temporary drop scope.I tried to find a more complete fix for it, but seems all too heavy, which involve AST visitor or need
hirrelated stuff.Instead of teaching this lint to reason about semantics, so it's better to stop linting those argument-position braces in 2024 later edition.