large_enums mir pass: fix is_enabled logic#154375
Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Open
large_enums mir pass: fix is_enabled logic#154375RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
wesleywiser
approved these changes
Mar 25, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 26, 2026
large_enums mir pass: fix is_enabled logic This logic got turned from a guard in `run_pass` to an `is_enabled` check in rust-lang@15d4728#r2989096960, but that was done incorrectly. The pass must never be enabled without `unsound_mir_opts`!
Member
Author
|
@bors r- |
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154411), which was unapproved. |
Member
Author
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic got turned from a guard in
run_passto anis_enabledcheck in 15d4728#r2989096960, but that was done incorrectly. The pass must never be enabled withoutunsound_mir_opts!