Add more robust handling of nested query cycles#154389
Draft
Zoxc wants to merge 2 commits intorust-lang:mainfrom
Draft
Add more robust handling of nested query cycles#154389Zoxc wants to merge 2 commits intorust-lang:mainfrom
Zoxc wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-query-system
Contributor
Author
|
The nested query cycles are currently printed as errors as I don't think we have the mechanism to resume after emitting a bug. This means we have 2 tests that are failing which were previously "undetected". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more robust handling of query cycle that occur while we are already printing a query cycle error. Such nested query cycle are compiler bugs and this adds special handling so that both the nested query cycle and the outer query cycle are printed. Doubly nested query cycle errors are ignored to prevent infinite recursion.
This is based on #153999