Skip to content

Enhance documentation on wake call memory ordering#154401

Open
xmh0511 wants to merge 1 commit intorust-lang:mainfrom
xmh0511:main
Open

Enhance documentation on wake call memory ordering#154401
xmh0511 wants to merge 1 commit intorust-lang:mainfrom
xmh0511:main

Conversation

@xmh0511
Copy link
Contributor

@xmh0511 xmh0511 commented Mar 26, 2026

Add documentation about memory ordering requirements for wake calls. Try to fix #128920

Add documentation about memory ordering requirements for wake calls.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Diff in /checkout/library/alloc/src/task.rs:39:
 ///
 /// # Memory Ordering
 ///
-/// The executor must guarantee that the call to `wake` _happens-before_ the corresponding woken `poll`. 
-/// In addition, the executor must also guarantee that multiple calls to `wake` that were coalesced into a single 
+/// The executor must guarantee that the call to `wake` _happens-before_ the corresponding woken `poll`.
+/// In addition, the executor must also guarantee that multiple calls to `wake` that were coalesced into a single
 /// `poll()` invocation all _happens-before_ the corresponding woken `poll`.
 ///
 /// # Examples
fmt: checked 6759 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:00:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Happens-before relationship between wake and poll

4 participants