Add tracking of query call locations#154402
Draft
Zoxc wants to merge 5 commits intorust-lang:mainfrom
Draft
Conversation
rustbot
added
A-query-system
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
query-call-tracking
branch
from
f641c01 to
4197e18
Compare
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
query-call-tracking
branch
from
4197e18 to
3ac1303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tracking of query call locations using
#[track_caller]in additional to associating query calls with a span.Query call locations are printed for query panic stack traces and for
-Z verbose-internals. The latter being helpful to track down accidental query cycles.