Skip to content

Rollup of 2 pull requests#154412

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-4EpQJse
Mar 26, 2026
Merged

Rollup of 2 pull requests#154412
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-4EpQJse

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Zoxc and others added 4 commits March 26, 2026 00:40
Ensure `ErasedData` only implements appropriate auto traits

This uses an external type to prevent auto traits to be inferred on `ErasedData`. That inference is incorrect since it may not store the type it declares.

This also implements `DynSend` and `DynSync` on `ErasedData` which are checked by bounds on `erase_val`.

Some diagnostics bounds were missing `DynSync`, which is also added here.
…KO8Ki

Update `try_blocks` to a new tracking issue number

New tracking issue rust-lang#154391
Closes rust-lang#31436
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 26, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Mar 26, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 26, 2026

📌 Commit e06b9bb has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 26, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 30s
Pushing 3a933e5 to main...

@rust-bors rust-bors bot merged commit 3a933e5 into rust-lang:main Mar 26, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 26, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3ea2fbc (parent) -> 3a933e5 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3a933e5bf5b695faf9e09d47a263a20c6b85c26a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-miri: 1h 19m -> 1h 36m (+21.6%)
  2. pr-check-1: 28m 20s -> 33m 31s (+18.3%)
  3. dist-aarch64-apple: 1h 31m -> 1h 47m (+17.7%)
  4. i686-gnu-2: 1h 29m -> 1h 45m (+17.2%)
  5. dist-i586-gnu-i586-i686-musl: 1h 41m -> 1h 25m (-15.8%)
  6. dist-x86_64-apple: 1h 44m -> 1h 59m (+14.1%)
  7. dist-armhf-linux: 1h 21m -> 1h 33m (+14.0%)
  8. optional-x86_64-gnu-parallel-frontend: 2h 22m -> 2h 41m (+13.2%)
  9. dist-aarch64-msvc: 1h 37m -> 1h 49m (+12.5%)
  10. aarch64-apple: 2h 36m -> 2h 55m (+12.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3a933e5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Cycles

Results (primary 2.3%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) 2.3% [2.3%, 2.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 485.545s -> 484.487s (-0.22%)
Artifact size: 395.12 MiB -> 395.09 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants