refactor `TypeRelativePath::AssocItem` to use `AliasTerm` by josetorrs · Pull Request #155323 · rust-lang/rust

josetorrs · 2026-04-15T02:33:47Z

View all comments

r? @WaffleLapkin

related issue: #154941

tackling the task:

remove calls to new_from_def_id and alias_ty_kind_from_def_id and replace them with calls to e.g. new_projection directly

also doing:

probe_inherent_assoc_item returns AliasTerm<'tcx>

rustbot · 2026-04-15T02:34:11Z

WaffleLapkin is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2026-04-15T10:24:16Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-04-16T01:31:06Z

HIR ty lowering was modified

cc @fmease

WaffleLapkin · 2026-05-01T10:39:33Z

r? fmease

fmease

Sorry for the delay! Could you apply my suggestions, update PR title and the PR description which seem to be outdated and squash all commits into one? Thanks!

View changes since this review

fmease · 2026-05-07T11:26:32Z


            // FIXME(inherent_associated_types, #106719): Support self types other than ADTs.
-            if let Some((did, args)) = self.probe_inherent_assoc_item(
+            if let Some((def_id, args)) = self.probe_inherent_assoc_item(


Could you make probe_inherent_assoc_item return an AliasTerm? So return a Result<Option<ty::AliasTerm<'tcx>>, ErrorGuaranteed>?

Additionally you could make lower_assoc_item_path return an AliasTerm directly to mirror the inherent counterpart but it's probably not worth it.

okay I think I got everything. I looked at implementing the lower_assoc_item_path suggestion and personally prefer the type clarity with AliasTerm but like you said not sure if it's worth it. though if you have second thoughts, then I would be happy to make the change

fmease after rebasing, a test from #155341 failed I think due to the AliasTerm return type change. I added a require_type_const_attribute check but admittedly not sure where this fits in now with #156181

rustbot · 2026-05-15T02:33:01Z

The Clippy subtree was changed

cc @rust-lang/clippy

…y_kind_from_def_id and new_from_def_id

rustbot · 2026-06-10T02:37:04Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

josetorrs · 2026-06-10T12:04:02Z

@rustbot ready

fmease · 2026-06-10T21:32:24Z

@bors r+ rollup

rust-bors · 2026-06-10T21:32:26Z

📌 Commit 24c895a has been approved by fmease

It is now in the queue for this repository.

@WaffleLapkin

…r=fmease refactor `TypeRelativePath::AssocItem` to use `AliasTerm` r? @WaffleLapkin related issue: rust-lang#154941 tackling the task: - [ ] remove calls to `new_from_def_id` and `alias_ty_kind_from_def_id` and replace them with calls to e.g. `new_projection` directly also doing: - `probe_inherent_assoc_item` returns `AliasTerm<'tcx>`

@WaffleLapkin

…r=fmease refactor `TypeRelativePath::AssocItem` to use `AliasTerm` r? @WaffleLapkin related issue: rust-lang#154941 tackling the task: - [ ] remove calls to `new_from_def_id` and `alias_ty_kind_from_def_id` and replace them with calls to e.g. `new_projection` directly also doing: - `probe_inherent_assoc_item` returns `AliasTerm<'tcx>`

@WaffleLapkin

…r=fmease refactor `TypeRelativePath::AssocItem` to use `AliasTerm` r? @WaffleLapkin related issue: rust-lang#154941 tackling the task: - [ ] remove calls to `new_from_def_id` and `alias_ty_kind_from_def_id` and replace them with calls to e.g. `new_projection` directly also doing: - `probe_inherent_assoc_item` returns `AliasTerm<'tcx>`

@WaffleLapkin

…r=fmease refactor `TypeRelativePath::AssocItem` to use `AliasTerm` r? @WaffleLapkin related issue: rust-lang#154941 tackling the task: - [ ] remove calls to `new_from_def_id` and `alias_ty_kind_from_def_id` and replace them with calls to e.g. `new_projection` directly also doing: - `probe_inherent_assoc_item` returns `AliasTerm<'tcx>`

Rollup of 31 pull requests Successful merges: - #141030 (Expand free alias types during variance computation) - #154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - #155527 (Replace printables table with `unicode_data.rs` tables) - #156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - #155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157196 (Only suggest reborrowing a moved value where the reborrow is valid) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)

@WaffleLapkin

Rollup merge of #155323 - josetorrs:remove-new-from-def-id, r=fmease refactor `TypeRelativePath::AssocItem` to use `AliasTerm` r? @WaffleLapkin related issue: #154941 tackling the task: - [ ] remove calls to `new_from_def_id` and `alias_ty_kind_from_def_id` and replace them with calls to e.g. `new_projection` directly also doing: - `probe_inherent_assoc_item` returns `AliasTerm<'tcx>`

Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned WaffleLapkin Apr 15, 2026

fmease requested changes Apr 15, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

josetorrs mentioned this pull request Apr 16, 2026

remove new_from_def_id and alias_ty_kind_from_def_id #155371

Closed

1 task

josetorrs marked this pull request as ready for review April 16, 2026 01:31

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2026

rustbot assigned fmease and unassigned WaffleLapkin May 1, 2026

josetorrs requested a review from fmease May 3, 2026 16:09

fmease approved these changes May 7, 2026

View reviewed changes

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2026

This comment has been minimized.

Sign in to view

josetorrs force-pushed the remove-new-from-def-id branch from 7c65730 to 1d2a312 Compare May 9, 2026 16:09

This comment has been minimized.

Sign in to view

josetorrs changed the title ~~removing new_from_def_id and alias_ty_kind_from_def_id methods, small refactor to TypeRelativePath::AssocItem~~ refactor TypeRelativePath::AssocItem to use AliasTerm May 9, 2026

This comment has been minimized.

Sign in to view

refactor TypeRelativePath::AssocItem to use AliasTerm, remove alias_t…

0863e17

…y_kind_from_def_id and new_from_def_id

josetorrs force-pushed the remove-new-from-def-id branch from 08738f1 to 0863e17 Compare June 10, 2026 02:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2026

fmease reviewed Jun 10, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

HIR ty lowering: Turn comment into FIXME

24c895a

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2026

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 28 pull requests #157735

Closed

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 31 pull requests #157739

Merged

rust-bors Bot merged commit 334687c into rust-lang:main Jun 11, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 11, 2026

Uh oh!

Conversation

josetorrs commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

rustbot commented Apr 16, 2026

Uh oh!

WaffleLapkin commented May 1, 2026

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fmease May 7, 2026

Choose a reason for hiding this comment

Uh oh!

josetorrs May 9, 2026

Choose a reason for hiding this comment

Uh oh!

josetorrs May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented May 15, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 10, 2026

Uh oh!

josetorrs commented Jun 10, 2026

Uh oh!

Uh oh!

fmease commented Jun 10, 2026

Uh oh!

rust-bors Bot commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

josetorrs commented Apr 15, 2026 •

edited

Loading

fmease left a comment •

edited by rustbot

Loading

josetorrs May 15, 2026 •

edited

Loading