compiletest: ignore SVG `y` offset in by-lines comparison by xmakro · Pull Request #157350 · rust-lang/rust

xmakro · 2026-06-03T01:28:12Z

SVG diagnostic snapshots render one terminal row per line, laid out top to bottom. Under the parallel front-end, independent diagnostics can be emitted in a different order. That permutes the rows and re-renders each one at a different vertical y offset, even though the content of every row is unchanged.

This change strips the y coordinate (and the <svg> header line, whose width and height are already ignored by the exact comparison) before the multiset comparison, so a reordering of whole rows is no longer treated as a difference.

rustbot · 2026-06-03T02:53:12Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-06-03T02:53:15Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clubby789 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, oli-obk

rustbot · 2026-06-10T00:32:06Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-06-10T12:25:49Z

@rustbot author to address the last two comments.

rustbot · 2026-06-10T12:25:51Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

petrochenkov · 2026-06-10T17:18:12Z

@bors r+ rollup

rust-bors · 2026-06-10T17:18:15Z

📌 Commit 1c511f4 has been approved by petrochenkov

It is now in the queue for this repository.

…r=petrochenkov compiletest: ignore SVG `y` offset in by-lines comparison Tracked in rust-lang#154314. Closes rust-lang#157606 SVG diagnostic snapshots render one terminal row per line, laid out top to bottom. Under the parallel front-end, independent diagnostics can be emitted in a different order. That permutes the rows and re-renders each one at a different vertical `y` offset, even though the content of every row is unchanged. This change strips the `y` coordinate (and the `<svg>` header line, whose width and height are already ignored by the exact comparison) before the multiset comparison, so a reordering of whole rows is no longer treated as a difference.

Rollup of 23 pull requests Successful merges: - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157384 (Add `#[rustc_dump_generics]` attribute) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157697 (Add more tests that exercise the well-formedness checking of lazy type aliases) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)

…r=petrochenkov compiletest: ignore SVG `y` offset in by-lines comparison Tracked in rust-lang#154314. Closes rust-lang#157606 SVG diagnostic snapshots render one terminal row per line, laid out top to bottom. Under the parallel front-end, independent diagnostics can be emitted in a different order. That permutes the rows and re-renders each one at a different vertical `y` offset, even though the content of every row is unchanged. This change strips the `y` coordinate (and the `<svg>` header line, whose width and height are already ignored by the exact comparison) before the multiset comparison, so a reordering of whole rows is no longer treated as a difference.

Rollup of 31 pull requests Successful merges: - #141030 (Expand free alias types during variance computation) - #154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - #155527 (Replace printables table with `unicode_data.rs` tables) - #156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - #155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157196 (Only suggest reborrowing a moved value where the reborrow is valid) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)

Rollup merge of #157350 - xmakro:fix/parallel-svg-y-offset, r=petrochenkov compiletest: ignore SVG `y` offset in by-lines comparison Tracked in #154314. Closes #157606 SVG diagnostic snapshots render one terminal row per line, laid out top to bottom. Under the parallel front-end, independent diagnostics can be emitted in a different order. That permutes the rows and re-renders each one at a different vertical `y` offset, even though the content of every row is unchanged. This change strips the `y` coordinate (and the `<svg>` header line, whose width and height are already ignored by the exact comparison) before the multiset comparison, so a reordering of whole rows is no longer treated as a difference.

Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)

xmakro marked this pull request as ready for review June 3, 2026 02:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026

rustbot assigned clubby789 Jun 3, 2026

petrochenkov self-assigned this Jun 3, 2026

petrochenkov reviewed Jun 3, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs Outdated

zetanumbers reviewed Jun 5, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs Outdated

xmakro force-pushed the fix/parallel-svg-y-offset branch 2 times, most recently from 01b7983 to bb47676 Compare June 5, 2026 17:03

zetanumbers mentioned this pull request Jun 8, 2026

SVG parallel frontend UI test failure #157606

Closed

This comment has been minimized.

Sign in to view

clubby789 reviewed Jun 9, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs Outdated

zetanumbers reviewed Jun 9, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs Outdated

xmakro force-pushed the fix/parallel-svg-y-offset branch from bb47676 to ebd0a7f Compare June 10, 2026 00:32

zetanumbers reviewed Jun 10, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs

zetanumbers reviewed Jun 10, 2026

View reviewed changes

Comment thread src/tools/compiletest/src/runtest.rs

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2026

compiletest: ignore SVG y offset in by-lines comparison

1c511f4

xmakro force-pushed the fix/parallel-svg-y-offset branch from ebd0a7f to 1c511f4 Compare June 10, 2026 16:44

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2026

jhpratt mentioned this pull request Jun 10, 2026

Rollup of 23 pull requests #157726

Closed

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 28 pull requests #157735

Closed

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 31 pull requests #157739

Merged

rust-bors Bot merged commit 008197d into rust-lang:main Jun 11, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compiletest: ignore SVG `y` offset in by-lines comparison#157350

compiletest: ignore SVG `y` offset in by-lines comparison#157350
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
xmakro:fix/parallel-svg-y-offset

xmakro commented Jun 3, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

rust-bors Bot commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

xmakro commented Jun 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

rustbot commented Jun 3, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

rust-bors Bot commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xmakro commented Jun 3, 2026 •

edited by rustbot

Loading