resolve: Remove exported imports from `maybe_unused_trait_imports` by petrochenkov · Pull Request #157713 · rust-lang/rust

petrochenkov · 2026-06-10T15:55:11Z

If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints.

Fixes #157420.

rustbot · 2026-06-10T15:55:16Z

Failed to set assignee to oli-obk: req=https://api.github.com/repos/rust-lang/rust/issues/157713/assignees (x-github-request-id: 5097:A6A96:89536D3:8ABE783:6A2988E1): {
"message": "Requires authentication",
"documentation_url": "https://docs.github.com/rest",
"status": "401"
}

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2026-06-10T15:55:16Z

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 16 candidates

petrochenkov · 2026-06-10T15:58:13Z

I'm not yet sure why the issue doesn't happen in simpler cases like

pub use module::Trait; // exported, but not used locally

mod module {
    pub trait Trait {}
}

/// [S::assoc]
pub struct S {}

, such imports are probably marked as "used" in some other way, but in any case the change in this PR should be correct, and it fixes the regression.

petrochenkov · 2026-06-10T16:16:16Z

why the issue doesn't happen in simpler cases

This is why:
https://github.com/rust-lang/rust/blob/main/compiler/rustc_hir_analysis/src/check_unused.rs#L41-L43

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-11T07:49:52Z

📌 Commit b4a1fc7 has been approved by oli-obk

It is now in the queue for this repository.

resolve: Remove exported imports from `maybe_unused_trait_imports` If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints. Fixes rust-lang#157420.

rustbot · 2026-06-11T14:51:28Z

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

resolve: Remove exported imports from `maybe_unused_trait_imports` If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints. Fixes rust-lang#157420.

mu001999 · 2026-06-11T15:31:13Z

So why does #154149 break this?

resolve: Remove exported imports from `maybe_unused_trait_imports` If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints. Fixes rust-lang#157420.

…uwer Rollup of 23 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #152852 (Remove driver_lint_caps) - #155299 (make repr_transparent_non_zst_fields a hard error) - #155439 (Enable Cargo's new build-dir layout) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

resolve: Remove exported imports from `maybe_unused_trait_imports` If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints. Fixes rust-lang#157420.

…uwer Rollup of 23 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #155299 (make repr_transparent_non_zst_fields a hard error) - #155439 (Enable Cargo's new build-dir layout) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

Rollup of 24 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #155299 (make repr_transparent_non_zst_fields a hard error) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data) - #155113 (Ensure Send/Sync impl for std::process::CommandArgs) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157723 (Move uninhabited unreachable code lint to rustc_mir_transform) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

Rollup merge of #157713 - petrochenkov:regr197unused, r=oli-obk resolve: Remove exported imports from `maybe_unused_trait_imports` If an import is visible from outside of the crate, then it's effectively used and shouldn't be reported by any kinds of unused import lints. Fixes #157420.

[beta] backports - Revert "Build shared LLVM lib for windows-gnullvm" #156962 - Allow building the source tarballs while offline #157014 - resolve: Partially revert "Remove a special case for dummy imports" #157719 - resolve: Remove exported imports from `maybe_unused_trait_imports` #157713 - [beta-1.97] Update cargo submodule #157792 r? cuviper

petrochenkov added 2 commits June 10, 2026 18:41

Add a regression test for issue 157420

ea1e984

resolve: Remove exported imports from maybe_unused_trait_imports

b4a1fc7

rustbot assigned oli-obk Jun 10, 2026

petrochenkov mentioned this pull request Jun 10, 2026

1.97 beta regression: Rust claims import is unused but crate doesn't compile with it removed #157420

Closed

petrochenkov added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2026

oli-obk approved these changes Jun 11, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2026

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 11, 2026

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 13 pull requests #157759

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 13 pull requests #157761

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 12 pull requests #157765

Closed

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 11, 2026

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 16 pull requests #157775

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 23 pull requests #157784

Closed

cuviper mentioned this pull request Jun 11, 2026

[beta] backports #157787

Merged

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 23 pull requests #157790

Closed

jhpratt mentioned this pull request Jun 12, 2026

Rollup of 24 pull requests #157794

Merged

rust-bors Bot merged commit 0950899 into rust-lang:main Jun 12, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 12, 2026

cuviper modified the milestones: 1.98.0, 1.97.0 Jun 12, 2026

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

resolve: Remove exported imports from `maybe_unused_trait_imports`#157713

resolve: Remove exported imports from `maybe_unused_trait_imports`#157713
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
petrochenkov:regr197unused

petrochenkov commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

petrochenkov commented Jun 10, 2026 •

edited

Loading

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

oli-obk left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

rustbot commented Jun 11, 2026

Uh oh!

mu001999 commented Jun 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

petrochenkov commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

petrochenkov commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Jun 10, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

rustbot commented Jun 11, 2026

Uh oh!

mu001999 commented Jun 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petrochenkov commented Jun 10, 2026 •

edited

Loading

oli-obk left a comment •

edited by rustbot

Loading