Match expressions had not been updated to also show the match_source,…#157769
Open
AlexCeleste wants to merge 1 commit into
Open
Match expressions had not been updated to also show the match_source,…#157769AlexCeleste wants to merge 1 commit into
AlexCeleste wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
r? @Nadrieril maybe, I'm not sure what this is about |
Collaborator
|
|
AlexCeleste
force-pushed
the
thir-missing-match-source
branch
from
406d85a to
ac251f4
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
AlexCeleste
force-pushed
the
thir-missing-match-source
branch
from
ac251f4 to
4da45bc
Compare
This comment has been minimized.
This comment has been minimized.
… since the time that was added update existing match tests as well remove hashes from output remove specific DefIds for core from output
AlexCeleste
force-pushed
the
thir-missing-match-source
branch
from
4da45bc to
481db97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… since the time that was added