perf: reuse green-marking's edge walk when promoting a node#157781
Draft
xmakro wants to merge 1 commit into
Draft
perf: reuse green-marking's edge walk when promoting a node#157781xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
saethlin
reviewed
Jun 11, 2026
| // Find the highest edge in the new dep node indices | ||
| let edge_max = | ||
| edges.clone().map(|i| colors.current(i).unwrap().as_u32()).max().unwrap_or(0); | ||
| // Explicit loop: `iter().max()` doesn't inline here, so it doesn't vectorize. |
Member
There was a problem hiding this comment.
I would love to see a smaller reproducer of this missed optimization
Member
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
perf: reuse green-marking's edge walk when promoting a node
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (2132d40): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.9%, secondary 3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 518.142s -> 518.408s (0.05%) |
rustbot
removed
the
S-waiting-on-perf
xmakro
force-pushed
the
perf/dep-graph-edge-reuse
branch
3 times, most recently
from
990196d to
47a8a51
Compare
xmakro
force-pushed
the
perf/dep-graph-edge-reuse
branch
from
47a8a51 to
a4fd621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.