Add regression test for pclmulqdq inlining across target feature#157791
Open
kohsine wants to merge 1 commit into
Open
Add regression test for pclmulqdq inlining across target feature#157791kohsine wants to merge 1 commit into
kohsine wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
folkertdev
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
r? me
It would be better to use minicore for this test, so it runs regardless of the host. There are plenty of examples of this, these tests use
//@ add-minicore
//@ compile-flags: -Copt-level=3 --target x86_64-unknown-linux-gnu
//@ needs-llvm-components: x86
#![feature(no_core)]
#![no_core]
extern crate minicore;
use minicore::*;
Contributor
|
Ah sorry, this wants to test |
folkertdev
requested changes
Jun 12, 2026
Comment on lines
+12
to
+14
| // CHECK-LABEL: @reduce128_caller | ||
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq | ||
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq |
Contributor
There was a problem hiding this comment.
Currently this only tests that
- the
reduce128_callerfunction exists call <2 x i64> @llvm.x86.pclmulqdqoccurs twice.
But this doesn't test that reduce128 actually got inlined.
| reduce128(a, b, keys) | ||
| } | ||
|
|
||
| unsafe fn reduce128(a: arch::__m128i, b: arch::__m128i, keys: arch::__m128i) -> arch::__m128i { |
Contributor
There was a problem hiding this comment.
Suggested change
| unsafe fn reduce128(a: arch::__m128i, b: arch::__m128i, keys: arch::__m128i) -> arch::__m128i { | |
| // CHECK-LABEL: @reduce128 | |
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq | |
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq | |
| #[no_mangle] | |
| unsafe fn reduce128(a: arch::__m128i, b: arch::__m128i, keys: arch::__m128i) -> arch::__m128i { |
With these additional checks the call <2 x i64> @llvm.x86.pclmulqdq must occur 4 times in total, proving that inlining occurred.
|
|
||
| //! Regression test for https://github.com/rust-lang/rust/issues/139029 | ||
| //! | ||
| //! pclmulqdq intrinsics should inline across target_feature |
Contributor
There was a problem hiding this comment.
Suggested change
| //! pclmulqdq intrinsics should inline across target_feature | |
| //! The pclmulqdq intrinsics should inline into functions with the required target features. | |
| *[View changes since the review](https://triagebot.infra.rust-lang.org/gh-changes-since/rust-lang/rust/157791/d2f24127d97d8c795d1cf5fbf6037f9885f34d39..e497947ec34512d57dd5fb3a0e24871c7c97337e)* |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for #139029.
Checks that pclmulqdq intrinsics inline across target_feature.