Refactor libproc_macro: remove * imports#157793
Open
Mark-Simulacrum wants to merge 2 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-author
lqd
reviewed
Jun 12, 2026
| use std::num::NonZero; | ||
|
|
||
| use super::*; | ||
| use crate::bridge::{Buffer, Decode, Encode, Mark, arena, client, fxhash, server}; |
Member
There was a problem hiding this comment.
this reminds me we could update the vendored fxhash source with a more recent version
Member
Author
There was a problem hiding this comment.
I think we should be able to take a crate dependency these days (maybe with some tweaks to the source of rustc-hash), but yeah, we should do that.
lqd
approved these changes
Jun 12, 2026
bjorn3
approved these changes
Jun 12, 2026
rustbot
added
S-waiting-on-review
Member
Author
|
Just put in draft while waiting for CI to pass, but I think future work can land in separate PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors out (and goes a bit further) some of the work from #157590 which I think can/should be merged independently of the wasm proc macros strategy, since it just makes it easier to read code in the bridge. It was confusing to get warnings/errors when commenting code that looked unused but was actually pulled in due to the
*imports from other modules.This also factors the panic message into a separate module since it's not really related to
rpcin a direct sense.Best reviewed by-commit.
r? bjorn3 since you've probably at least glanced at this code recently, but happy to re-roll if you'd prefer.