Skip to content

Rollup of 14 pull requests#157809

Closed
JonathanBrouwer wants to merge 35 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-caxdN5C
Closed

Rollup of 14 pull requests#157809
JonathanBrouwer wants to merge 35 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-caxdN5C

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Darksonn and others added 30 commits May 29, 2026 06:15
To make the distinction clearer versus `macos-26` runners in preparation
of experimenting with running `macos-26` runners in parallel.
Which mirrors the `aarch64-apple` `macos-15` runner image based
workloads, but run on `macos-26` runner image, to evaluate running
times.

See RUST-157687.
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
* add #[rustc_no_writable] to slice::get_unchecked_mut
* add #[rustc_no_writable] to slice::get_mut
* add unchecked_mut miri test
…rrow-tests, r=aapoalas

Add field-wise CoerceShared reborrow tests

Title. Split from rust-lang#157101
r? @aapoalas
…omatsakis

Make Share::share final and improve docs

Tracking issue: rust-lang#156756

This follows up on the initial unstable `Share` trait added in rust-lang#156828.

The original API used an ordinary default method:

```rust
fn share(&self) -> Self {
    Clone::clone(self)
}
```

Niko pointed out that `share` should be final, since `Share` is meant to communicate the semantics of `Clone::clone` for clone-as-alias types, not provide a second independently-overridable operation.

`Share` remains unstable under `#![feature(share_trait)]`.

r? @nikomatsakis
… r=Kobzol

Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images

## Summary

Add a new experimental `aarch64-apple-macos-26` test job which runs `aarch64-apple`-equivalent workloads on `macos-26` runner image, to evalute the running time of using `macos-26` runner images over multiple Merge CI runs.

This experiment is tracked by rust-lang#157687.

> [!NOTE]
>
> If this test job hangs, times out, becomes the new slowest job, or produces other issues, please revert this PR and let @jieyouxu know.

## Additional context

See:

* rust-lang#157687
* [#t-infra > GHA macos-26 slowness](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/GHA.20macos-26.20slowness/with/601617248)

r? infra-ci
…r,RalfJung

Test that you can't implement Unpin for a compiler-generated future using TAIT

I came up with this while trying to break pinning. Seems like a good idea to have a test that this doesn't change.

r? @RalfJung
…fns, r=RalfJung

add #[rustc_no_writable] to slice::get_unchecked_mut

This PR adds the `#[rustc_no_writable]` attribute introduced in rust-lang#155207 to the `slice::get_unchecked_mut` function.

Two library functions already received this attribute, as they were known to cause problems with the llvm writable attribute and tree borrows. Since that PR, I ran Miri on the 30'000 most downloaded crates to see what kind of code is now UB under Tree Borrows + implicit writes, using the detection implemented in rust-lang/miri#4947. Adding this attribute to ignore checking for this function reduced the new UB introduced by more than 75%, meaning that instead of 19000 tests in 1700 crates having a difference, now only 3500 in 350 crates show a difference (measurement still running).
…adics, r=RalfJung,folkertdev

Disable retagging for variadic arguments in const-eval

Fixes [rust-lang#5058](rust-lang/miri#5058) in Miri.

Retags occur on typed copies, which happen when we pass variadic arguments to a function. At the moment, variadic arguments receive `RetagMode::FnEntry` retags, which protects their permissions for the duration of the call. However, protection needs to be based on callee-side information, and the callee has now way of knowing what's contained within its `VaList`.

This PR disables retagging entirely when copying variable arguments. It also adds a new, passing test case that would originally fail before this change.

cc: @RalfJung, @folkertdev
…r_relating, r=lcnr

-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver

r? lcnr

fixes rust-lang#157678

computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
…able-generic, r=lcnr

Extend capabilities of `TypeFoldable_Generic`

Split from rust-lang#156538.

- Lets `TypeFoldable_Generic` derive structural folding for types with extra generic parameters by adding the necessary `T: TypeFoldable<I>` bounds automatically
- Means in rust-lang#156538 we can remove the manual `TypeFoldable` implementation for `NormalizesTo`
- Refactors shared traversal logic between `Lift_Generic` and `TypeFoldable_Generic` into a shared helper with a callback.

r? @lcnr
…3, r=JonathanBrouwer

Rename `errors.rs` file to `diagnostics.rs` (6/N)

Follow-up of rust-lang#157485.

r? @JonathanBrouwer
interpret: avoid computing layout of sized raw pointee

This lets the [example](rust-lang#157654 (comment)) by @theemathas work in Miri.
…ort, r=nnethercote

fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia
revert 157013

revert rust-lang#157013

to open it again with crater and fcp this time

cc @BoxyUwU

r? lcnr
… r=JonathanBrouwer

Rename `errors.rs` file to `diagnostics.rs` (7/N)

Follow-up of rust-lang#157485.

r? @JonathanBrouwer
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 12, 2026
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0a85379 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026
@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit 0a85379 with merge a792820

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/27414797857

rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
Rollup of 14 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2026
@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved due to being closed.

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors try cancel

@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.