Rollup of 9 pull requests

[jhpratt]

Successful merges:

• remove AliasTerm::def_id() #157653 (remove AliasTerm::def_id())
• Remove AnonConstKind::GCA and reject generic anon consts #157773 (Remove AnonConstKind::GCA and reject generic anon consts)
• Avoid ICE in unconstrained generic parameter suggestion for enums #157846 (Avoid ICE in unconstrained generic parameter suggestion for enums)
• [tiny] Use multipart suggestion for finding ident when literal was expected in attr #157514 ([tiny] Use multipart suggestion for finding ident when literal was expected in attr)
• rustdoc: correct doctest span for trailing semicolon after item #157740 (rustdoc: correct doctest span for trailing semicolon after item)
• Added PhantomPinned diagnostic item and prevented dead field warning on PhantomPinned #157782 (Added PhantomPinned diagnostic item and prevented dead field warning on PhantomPinned)
• Ensure that optimize attributes on closures are inherited by the shim. #157802 (Ensure that optimize attributes on closures are inherited by the shim.)
• rustc_public: implement ty::Alias conversion #157812 (rustc_public: implement ty::Alias conversion)
• Update wasm-component-ld to 0.5.25 #157833 (Update wasm-component-ld to 0.5.25)

r? @ghost

Create a similar rollup

[jhpratt]

@bors r+ rollup=never p=5

[rust-bors]

📌 Commit 84fb59b has been approved by jhpratt

It is now in the queue for this repository.

[rust-log-analyzer]

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

diff of stderr:

2   --> $DIR/darwin-objc-bad-arg.rs:12:18
3    |
4 LL |     objc::class!(s);
-    |                  ^ help: try adding quotation marks: `"s"`
+    |                  ^
+    |
+ help: you might have meant to write a string literal
+    |
+ LL |     objc::class!("s");
+    |                  + +
6 
7 error: attribute value must be a literal
8   --> $DIR/darwin-objc-bad-arg.rs:15:18

9    |
10 LL |     objc::class!(NSObject);
-    |                  ^^^^^^^^ help: try adding quotation marks: `"NSObject"`
+    |                  ^^^^^^^^
+    |
+ help: you might have meant to write a string literal
+    |
+ LL |     objc::class!("NSObject");
+    |                  +        +
12 
13 error: `objc::class!` expected a string literal
14   --> $DIR/darwin-objc-bad-arg.rs:18:18

---
+    |                     ^
+    |
+ help: you might have meant to write a string literal
+    |
+ LL |     objc::selector!("s");
+    |                     + +
30 
31 error: attribute value must be a literal
32   --> $DIR/darwin-objc-bad-arg.rs:28:21

33    |
34 LL |     objc::selector!(alloc);
-    |                     ^^^^^ help: try adding quotation marks: `"alloc"`
+    |                     ^^^^^
+    |
+ help: you might have meant to write a string literal
+    |
+ LL |     objc::selector!("alloc");
+    |                     +     +
36 
37 error: `objc::selector!` expected a string literal
38   --> $DIR/darwin-objc-bad-arg.rs:31:21


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args darwin-objc/darwin-objc-bad-arg.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2/bin/rustc" "/Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/Users/runner/.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/Users/runner/work/rust/rust/vendor" "--sysroot" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2" "--target=aarch64-apple-darwin" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/ui/darwin-objc/darwin-objc-bad-arg" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/Users/runner/work/rust/rust/build/aarch64-apple-darwin/native/rust-test-helpers" "--edition=2024"
stdout: none
--- stderr -------------------------------
error: attribute value must be a literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:12:18
   |
LL |     objc::class!(s);
   |                  ^
   |
help: you might have meant to write a string literal
   |
LL |     objc::class!("s");
   |                  + +

error: attribute value must be a literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:15:18
   |
LL |     objc::class!(NSObject);
   |                  ^^^^^^^^
   |
help: you might have meant to write a string literal
   |
LL |     objc::class!("NSObject");
   |                  +        +

error: `objc::class!` expected a string literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:18:18
   |
LL |     objc::class!(123);
   |                  ^^^

error: `objc::class!` may not contain null characters
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:21:18
   |
LL |     objc::class!("NSObject\0");
   |                  ^^^^^^^^^^^^

error: attribute value must be a literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:25:21
   |
LL |     objc::selector!(s);
   |                     ^
   |
help: you might have meant to write a string literal
   |
LL |     objc::selector!("s");
   |                     + +

error: attribute value must be a literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:28:21
   |
LL |     objc::selector!(alloc);
   |                     ^^^^^
   |
help: you might have meant to write a string literal
   |
LL |     objc::selector!("alloc");
   |                     +     +

error: `objc::selector!` expected a string literal
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:31:21
   |
LL |     objc::selector!(123);
   |                     ^^^

error: `objc::selector!` may not contain null characters
##[error]  --> /Users/runner/work/rust/rust/tests/ui/darwin-objc/darwin-objc-bad-arg.rs:34:21
   |
LL |     objc::selector!("alloc\0");
   |                     ^^^^^^^^^

error: aborting due to 8 previous errors
------------------------------------------

[rust-bors]

💔 Test for 7c4ce9f failed: CI. Failed job:

• auto - aarch64-apple (web logs, enhanced plaintext logs)

[rust-bors]

PR #157514, which is a member of this rollup, was unapproved.