Skip to content

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Aug 14, 2020

It has been deny_by_default since 2017 (and warned for some time
before that), so it seems reasonable to promote it.

The specific technical motivation to do this now is to remove a field
from ParseSess -- it is a global state, and global state makes
extracting libraries annoying.

Closes #40107

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
@matklad
Copy link
Contributor Author

matklad commented Aug 14, 2020

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned varkor Aug 14, 2020
@matklad matklad force-pushed the remove-deprecation branch from 2718672 to 91ba6d4 Compare August 14, 2020 09:49
@matklad matklad added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 14, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 14, 2020
@jonas-schievink jonas-schievink added this to the 1.47 milestone Aug 14, 2020
@petrochenkov
Copy link
Contributor

The specific technical motivation to do this now is to remove a field
from ParseSess -- it is a global state, and global state makes
extracting libraries annoying.

You remove one today, tomorrow two more are added for diagnostics.
Have to run fast just to stay in the same place.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2020

📌 Commit 91ba6d47ae593573f943dc5e5433e6d11682c046 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2020
@Mark-Simulacrum
Copy link
Member

@bors rollup=never (could have perf implications though I don't really expect it)

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

⌛ Testing commit 91ba6d47ae593573f943dc5e5433e6d11682c046 with merge 010fa54dba0d327f682636d6702119548e5fc923...

@tmandry
Copy link
Member

tmandry commented Aug 15, 2020

@bors retry
yielding to rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

⌛ Testing commit 91ba6d47ae593573f943dc5e5433e6d11682c046 with merge 64295ac692af2e382fe3b749c19d554ba4e2320f...

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2020
@matklad
Copy link
Contributor Author

matklad commented Aug 15, 2020

The failure is genuine: cargotest tests a https://github.com/dzamlo/treeify project, which hasn't been updated in four years and depends on the old clap, which has a genuine bug in the macro definition.

I think we should remove treeify from cargotest (in comparision to other projects tested, it does feel like an outlier with only a single dep (clap) and small size).

However we might want to maybe run a crater here?

@matklad
Copy link
Contributor Author

matklad commented Aug 15, 2020

Hm, for some reason cargotest tests fails locally for me with some git error (?!), so let's

@bors try

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

⌛ Trying commit a07e52b22158978c7e6282c8c0ad183fde66af70 with merge 47ca8d06b142ea091021474a428f13a79a943058...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for future-incompatibility lint missing_fragment_specifier

8 participants