-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Promote missing_fragment_specifier to hard error #75516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
2718672 to
91ba6d4
Compare
You remove one today, tomorrow two more are added for diagnostics. @bors r+ |
|
📌 Commit 91ba6d47ae593573f943dc5e5433e6d11682c046 has been approved by |
|
@bors rollup=never (could have perf implications though I don't really expect it) |
|
⌛ Testing commit 91ba6d47ae593573f943dc5e5433e6d11682c046 with merge 010fa54dba0d327f682636d6702119548e5fc923... |
|
@bors retry |
|
⌛ Testing commit 91ba6d47ae593573f943dc5e5433e6d11682c046 with merge 64295ac692af2e382fe3b749c19d554ba4e2320f... |
|
💔 Test failed - checks-actions |
|
The failure is genuine: I think we should remove However we might want to maybe run a crater here? |
|
Hm, for some reason @bors try |
|
⌛ Trying commit a07e52b22158978c7e6282c8c0ad183fde66af70 with merge 47ca8d06b142ea091021474a428f13a79a943058... |
It has been deny_by_default since 2017 (and warned for some time
before that), so it seems reasonable to promote it.
The specific technical motivation to do this now is to remove a field
from
ParseSess-- it is a global state, and global state makesextracting libraries annoying.
Closes #40107