refactor: Turn the verifier crate into a library and rename it to surveyhero - #391
Conversation
verifier crate into a libraryverifier crate into a library and rename it to surveyhero
|
Could you please also update |
There was a problem hiding this comment.
There seem to be a few unrelated stylistic changes I would have prefered to be in a separate commit (or in a small PR aside) but overall it seems that you just moved code around and "opened" some structs and functions so they are accessible from the binary. Is that correct?
Looks good to me (after changes suggested by Jakub), unless I missed anything. Jakub feel free to have a second look!
Thanks @JayanAXHF
Done! |
Yes indeed! |
Kobzol
left a comment
There was a problem hiding this comment.
Thanks. I think that it is in general better if this is a library, we could use it for more interesting things in the future. One thing I'd love to see in general is having the export from a MD file to the SurveyHero text format, which could be imported into SH. That would really make live simpler for us when bootstrapping surveys (even if it won't be able to transfer all the details).
Sub PR for #388