Skip to content

refactor: Turn the verifier crate into a library and rename it to surveyhero - #391

Merged
Kobzol merged 3 commits into
rust-lang:mainfrom
JayanAXHF:verifier_lib
Jan 20, 2026
Merged

refactor: Turn the verifier crate into a library and rename it to surveyhero#391
Kobzol merged 3 commits into
rust-lang:mainfrom
JayanAXHF:verifier_lib

Conversation

@JayanAXHF

Copy link
Copy Markdown
Member

Sub PR for #388

Comment thread verifier/src/lib.rs Outdated
@JayanAXHF JayanAXHF changed the title refactor: Turn the verifier crate into a library refactor: Turn the verifier crate into a library and rename it to surveyhero Jan 19, 2026
@Kobzol

Kobzol commented Jan 20, 2026

Copy link
Copy Markdown
Member

Could you please also update README.md, and anything else that mentions the old verifier name? Thanks!

@apiraino apiraino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a few unrelated stylistic changes I would have prefered to be in a separate commit (or in a small PR aside) but overall it seems that you just moved code around and "opened" some structs and functions so they are accessible from the binary. Is that correct?

Looks good to me (after changes suggested by Jakub), unless I missed anything. Jakub feel free to have a second look!

Thanks @JayanAXHF

Comment thread surveyhero/src/api.rs
@JayanAXHF

Copy link
Copy Markdown
Member Author

Could you please also update README.md, and anything else that mentions the old verifier name? Thanks!

Done!

@JayanAXHF

Copy link
Copy Markdown
Member Author

overall it seems that you just moved code around and "opened" some structs and functions so they are accessible from the binary. Is that correct?

Yes indeed!
I also fixed a few clippy lints :)

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think that it is in general better if this is a library, we could use it for more interesting things in the future. One thing I'd love to see in general is having the export from a MD file to the SurveyHero text format, which could be imported into SH. That would really make live simpler for us when bootstrapping surveys (even if it won't be able to transfer all the details).

@Kobzol
Kobzol merged commit a7ee6b8 into rust-lang:main Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants