Don't raise reviewer already assigned when there are multiple assignees#2290
Merged
Urgau merged 1 commit intorust-lang:masterfrom Feb 17, 2026
Merged
Don't raise reviewer already assigned when there are multiple assignees#2290Urgau merged 1 commit intorust-lang:masterfrom
Urgau merged 1 commit intorust-lang:masterfrom
Conversation
Kobzol
approved these changes
Feb 17, 2026
| if issue.contain_assignee(&event.user().login) => | ||
| { | ||
| // If one of the assignee tries to assign another already assigned user, | ||
| // let it pass, as it means they wanted to be removed from the assignee list. |
Member
There was a problem hiding this comment.
What if there are three assignees (R1, R2, R3), and R1 sends r? R2, should it unassign R3? 😆
Member
Author
There was a problem hiding this comment.
No idea, it's a border line situation. I could see it go both ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happened in rust-lang/rust#151741 (comment)