Conversation
* feat(pumpkin-solver): add Pumpkin solver integration to Cargo features and solvers * build(pumpkin): add conditional compilation directives * fix: typo * build: cargo build success 🎉 * build: cargo builds again * fix: cargo builds 🎉 (2 unused warnings) * fix: new try * fix: solve simple problem test pass * test: solve easy and solve milp passing 🎉 * fix: tests were passing for the wrong reasons * fix(temporary): unsure how to set objective bounds properly, hotfix [-1000, +1000]
pumpkin_solver solver (#1)pumpkin_solver solver
lovasoa
left a comment
There was a problem hiding this comment.
The overall approach looks good to me. You may want to add some more tests, and update the README.
|
You also need to update the CI to test the new solver: https://github.com/rust-or/good_lp/blob/main/.github/workflows/rust.yml |
|
Thanks a lot, I added pumpkin-solver* to the table with a no on the WASM box but I am not actually sure if that is something that needs special support or if you get it out of the box via
*I feel like pumpkin would be a nicer feature name but I don’t know if it’s preferable to keep it exactly the same as the crate name… I’ll try using it with existing good_lp code and see if I can road test it this week, add those missing tests and try to find a solution to the objective var bounds |
I’m not sure about a couple of things here:
TODO
cargo test --no-default-features --features pumpkin-solvershould pass[-1000, +1000]hotfix)