Merged
Conversation
TeXitoi
commented
Nov 10, 2025
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 10, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 10, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
TeXitoi
force-pushed
the
add_some_lacking_status
branch
from
4f18c70 to
941bf52
Compare
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 10, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 10, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
TeXitoi
force-pushed
the
add_some_lacking_status
branch
from
941bf52 to
4a972f3
Compare
lovasoa
requested changes
Nov 10, 2025
Contributor
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
I think it's ok to make a new major version
…al_solution_status These modifications are needed if you configure HiGHS to stop before the end of the optimization. The added enum variant to HighsModelStatus and the added `#[non_exhaustive]` to it are breaking changes. fixes rust-or#26 depends on rust-or/highs-sys#37
TeXitoi
force-pushed
the
add_some_lacking_status
branch
from
4a972f3 to
522c507
Compare
Contributor
Author
|
I’ve added the |
Contributor
Author
|
I didn’t remove the Unknown variant, as it explicitly exists in HiGHS and I’m not sure that’s a "useless" error. |
lovasoa
approved these changes
Nov 12, 2025
Contributor
Author
|
Wow, that was fast! Thanks. |
Contributor
|
Thanks for your work @TeXitoi ! It's now live on crates.io |
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 12, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
TeXitoi
added a commit
to TeXitoi/good_lp
that referenced
this pull request
Nov 12, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
lovasoa
pushed a commit
to rust-or/good_lp
that referenced
this pull request
Nov 12, 2025
If you put a stopping option as `.set_option("mip_max_nodes", 10)`, the solver
might stop without finding a feasible solution. This modification handles this
case by checking that a feasible solution is available, returning
`Err(ResolutionError::Other("NoSolutionFound"))` if not.
depends on rust-or/highs#32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These modifications are needed if you configure HiGHS to stop before the end of the optimization.
The added enum variant to HighsModelStatus and the added
#[non_exhaustive]to it are breaking changes.fixes #26
depends on rust-or/highs-sys#37