examples/drm: Don't force card{i} enumeration to start at 0
#245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my setup with an AMD RX6800XT GPU (same happens with an Intel Arc GPU) there is only `card1` and `renderD128`. The example would fail with a "File not found" error for `/dev/dri/card0` when it should instead continue to iterate to find the first valid DRM device. A more future-proof solution would be to replace the `0..10` range with a `readdir()`-like iterator over the contents of `/dev/dri` if that's accepted for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my setup with an AMD RX6800XT GPU (same happens with an Intel Arc GPU) there is only
card1andrenderD128. The example would fail with a "File not found" error for/dev/dri/card0when it should instead continue to iterate to find the first valid DRM device.A more future-proof solution would be to replace the
0..10range with areaddir()-like iterator over the contents of/dev/driif that's accepted for an example. Note thatdrm 0.14.0added wrappers for dealing with/dev/drifiles and Smithay/drm-rs#208 is adding exactly the iterator we need to find the first valid device, which I'd recommend to use in our iterator instead when released :)