fix(skill,ci): restore ClawHub claw.json + dispatchable wallet-publish (Stage 4 re-review)#58
Merged
Merged
Conversation
…chable (Stage 4 re-review) Stage 4 (#57) landed with claw.json overwritten wholesale by a server.json copy — the ClawHub manifest fields (entry, permissions, tags, minOpenClawVersion, license, author) were lost. Restored from the 0.4.4 manifest with only the version bump and the approval-console sentence the Stage 4 spec asked for. wallet-publish.yml could not produce a build: it overrode the correct Dockerfile.wallet base pins with rustok-core:<git-ref> (nonexistent) and derived image tags from the git ref, which yields zero tags on a workflow_dispatch from a branch. Now the version comes in as a dispatch input, is verified against pyproject.toml before anything builds, and the base-image pins live only in Dockerfile.wallet. CONFIGURATION.md gets the /run/wallet approval-console section the Stage 4 spec required.
…r.json) The Stage 4 defect merged with green CI because nothing validates claw.json. Four checks now pin it: the ClawHub key set from the 0.4.4 baseline, the absence of MCP-registry schema keys, an entry file that exists, and a version that tracks pyproject.toml. Red proven against the actual defect artifact (server.json clone: 3 failures) and a version drift (1 failure); green 4/4 on the restored manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Фикс-PR по ре-ревью Этапа 4 (#57): финальный коммит той арки перезаписал
claw.jsonсодержимымserver.json, аwallet-publish.ymlне мог собрать 0.5.0.skills/rustok-wallet/claw.jsonвосстановлен в ClawHub-формате 0.4.4: версия0.5.0, в description добавлено предложение про approval-console. Diff против8a40956^— ровно 2 строки (version, description).wallet-publish.ymlтеперь запускаемый: обязательный inputversion→ guard-шаг сверяет его сpyproject.tomlдо сборки (ввод через env, без shell-интерполяции) → тегиvX.Y.Z/vX.Y/vXиз input (type=semver,value=…), а не из git-ref → удалёнCORE_IMAGE-override (пины базовых образов только вDockerfile.wallet) → шапка переписана под реальные предусловия (GHCR-пакетrustok-coreдолжен стать Public).docs/CONFIGURATION.md: секция «Approval console» (/run/wallet/approve.sock, правило второго окна) — требование спеки Этапа 4 §4.tests/test_claw_manifest.py: регрессионный гард — ClawHub-ключи присутствуют, server.json-ключей нет,entryсуществует, версия == pyproject. Red доказан против артефакта исходного дефекта (server.json-клон: 3 падения) и дрейфа версии (1 падение); green 4/4.Гейты
Ревью
Вне скоупа (для протокола)
Релизный поезд 0.5.0 (теги core/console, Public на GHCR-пакетах, ручной запуск wallet-publish) — следующий шаг плана; podman-tmpfs и upgrade-путь старых volume — заметки Этапу 6.