fix(mqtt): allow nonfatal advisory to start publisher - #1445
Open
TomGaussiran wants to merge 2 commits into
Open
fix(mqtt): allow nonfatal advisory to start publisher#1445TomGaussiran wants to merge 2 commits into
TomGaussiran wants to merge 2 commits into
Conversation
added 2 commits
July 26, 2026 17:46
Start the publisher when validation returns a non-fatal advisory, while continuing to reject fatal configuration errors. Cover valid, advisory, and fatal startup decisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MqttConfigError::is_fatal()and the existing MQTT example.src/main.rschanges.Why
MqttConfig::validate()intentionally returnsPlaintextOnPublicHostas a non-fatal advisory during the ADR-115 deprecation window. The sensing server treated every validation error as fatal, so a plaintext broker on another LAN host never started the publisher even though the error explicitly allowed startup.Test plan
No ESP32 firmware change is required.