Skip to content

fix(mqtt): allow nonfatal advisory to start publisher - #1445

Open
TomGaussiran wants to merge 2 commits into
ruvnet:mainfrom
TomGaussiran:fix/mqtt-advisory-startup
Open

fix(mqtt): allow nonfatal advisory to start publisher#1445
TomGaussiran wants to merge 2 commits into
ruvnet:mainfrom
TomGaussiran:fix/mqtt-advisory-startup

Conversation

@TomGaussiran

Copy link
Copy Markdown

Summary

  • Start the MQTT publisher when configuration validation returns a non-fatal advisory, matching MqttConfigError::is_fatal() and the existing MQTT example.
  • Continue blocking publisher startup for fatal configuration errors.
  • Add regression tests for valid, advisory, and fatal startup decisions.
  • Run those binary tests in the MQTT workflow and trigger the workflow for src/main.rs changes.

Why

MqttConfig::validate() intentionally returns PlaintextOnPublicHost as a non-fatal advisory during the ADR-115 deprecation window. The sensing server treated every validation error as fatal, so a plaintext broker on another LAN host never started the publisher even though the error explicitly allowed startup.

Test plan

  • MQTT startup regressions: 3 passed, 0 failed
  • MQTT-enabled library suite: 486 passed, 0 failed, 1 ignored
  • Mosquitto-backed integration suite: 3 passed, 0 failed
  • MQTT-enabled sensing-server build
  • Workflow YAML parsed successfully

No ESP32 firmware change is required.

Thomas Gaussiran added 2 commits July 26, 2026 17:46
Start the publisher when validation returns a non-fatal advisory, while continuing to reject fatal configuration errors. Cover valid, advisory, and fatal startup decisions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant