Upgrade semver of readable-stream from 3 to ^4.0.0#113
Upgrade semver of readable-stream from 3 to ^4.0.0#113Annniee1 wants to merge 2 commits intorvagg:masterfrom
Conversation
|
@brycebaril @maxogden @rvagg @styfle Please Have a look at this PR |
package.json
Outdated
| "license": "MIT", | ||
| "dependencies": { | ||
| "readable-stream": "3" | ||
| "readable-stream": "4.2.0" |
There was a problem hiding this comment.
| "readable-stream": "4.2.0" | |
| "readable-stream": "4" |
styfle
left a comment
There was a problem hiding this comment.
Seems fine although I don't have any authority here and didn't run the tests
|
@rvagg Please Review this PR |
|
🤦 CI is very out of date ... for a start, let's go with also the browser tests are broken, probably a bit of my fault too since it uses polendina .. which is mine and then, after all that, we'll need to semver-major this because of the drop of support for older version of Node.js |
|
Thanks for the detailed response @rvagg . Do we have some ETA for getting this fixed? |
|
@rvagg Is this repo still under maintenance / is this issue something that can be addressed / do you need help? |
|
if someone wants to help push this forward, I'd like to switch CI to use the same as in bl, https://github.com/rvagg/bl/tree/master/.github/workflows; having a failing CI means I can't merge this |
Upgrade semver of readable-stream from 3 to 4.2.0