fix: discover tinyxml2 via tinyxml2_vendor for cross-distro builds#2
Merged
Conversation
find_package(tinyxml2) only works where the system ships tinyxml2's CMake config (Ubuntu 24.04 / Jazzy) but not on 22.04 (Humble), whose libtinyxml2-dev 9.0 has none. Find tinyxml2 through tinyxml2_vendor (already a declared dependency), which prepends a FindTinyXML2 module and guarantees the tinyxml2::tinyxml2 target used by the ODR link fix. This is the same pattern ros2_control's hardware_interface uses. No behavior change on Jazzy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_package(tinyxml2) only works where the system ships tinyxml2's CMake config (Ubuntu 24.04 / Jazzy) but not on 22.04 (Humble), whose libtinyxml2-dev 9.0 has none. Find tinyxml2 through tinyxml2_vendor (already a declared dependency), which prepends a FindTinyXML2 module and guarantees the tinyxml2::tinyxml2 target used by the ODR link fix. This is the same pattern ros2_control's hardware_interface uses. No behavior change on Jazzy.