Skip to content

add nodeSelector flag (--node) using v1beta1#2

Closed
rxinui wants to merge 7 commits intomainfrom
ship-0039/260-v1beta1
Closed

add nodeSelector flag (--node) using v1beta1#2
rxinui wants to merge 7 commits intomainfrom
ship-0039/260-v1beta1

Conversation

@rxinui
Copy link
Copy Markdown
Owner

@rxinui rxinui commented Apr 21, 2025

Changes

Codebase is tracking shipwright-io#304 as .spec.NodeSelector is only defined on builds.shipwright.io/v1beta1. The current main branch for CLI still relies on builds.shipwright.io/v1alpha1

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Add flag --node to set the `.spec.nodeSelector` for `build` and `buildrun` on create

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0.
- [Commits](golang/net@v0.37.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@rxinui rxinui added the kind label Apr 21, 2025
@rxinui rxinui self-assigned this Apr 21, 2025
@rxinui rxinui force-pushed the ship-0039/260-v1beta1 branch from 4fb92dc to 37984fa Compare April 23, 2025 16:25
karanibm6 and others added 5 commits April 28, 2025 14:48
Signed-off-by: Karan Kumar <karan.kumar6@ibm.com>
…_modules/golang.org/x/net-0.38.0

Bump golang.org/x/net from 0.37.0 to 0.38.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.36.3 to 1.37.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.36.3...v1.37.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
…_modules/github.com/onsi/gomega-1.37.0

Bump github.com/onsi/gomega from 1.36.3 to 1.37.0
@rxinui rxinui force-pushed the ship-0039/260-v1beta1 branch from 37984fa to c73dfc3 Compare April 29, 2025 14:28
- test: add bats for `shp build run`
- test: add unit tests

Signed-off-by: rxinui <rainui.ly@gmail.com>
@rxinui rxinui force-pushed the ship-0039/260-v1beta1 branch from c73dfc3 to 3027458 Compare April 30, 2025 18:50
@rxinui rxinui closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants