Add wildcard subdomain matching in config host sections#374
Merged
ryanfowler merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
Support [*.example.com] syntax to match any subdomain of a domain. Exact matches take priority, and when multiple wildcards match, the most specific (longest suffix) wins.
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard subdomain matching support to the host configuration sections, allowing patterns like [*.example.com] to match any subdomain of a domain. Exact hostname matches take priority, and when multiple wildcard patterns match, the most specific (longest suffix) is selected.
Changes:
- Implemented validation for wildcard hostname patterns in the config parser
- Added
HostConfig()method to resolve hostname configurations with wildcard matching logic - Updated configuration lookup to use the new wildcard-aware resolution method
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.go | Refactored config lookup to use the new HostConfig() method instead of direct map access |
| internal/config/file.go | Added wildcard validation logic and implemented HostConfig() method for wildcard-aware hostname resolution |
| internal/config/file_test.go | Added comprehensive test coverage for wildcard validation and hostname matching scenarios |
| docs/configuration.md | Added documentation explaining wildcard subdomain matching syntax and matching rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support [*.example.com] syntax to match any subdomain of a domain. Exact matches take priority, and when multiple wildcards match, the most specific (longest suffix) wins.