Add gRPC client-side and bidirectional streaming support#380
Merged
ryanfowler merged 1 commit intomainfrom Feb 1, 2026
Merged
Conversation
Stream multiple JSON objects as individual gRPC frames using io.Pipe for incremental delivery. Detection is automatic via the proto schema's MethodDescriptor.IsStreamingClient(), requiring no new CLI flags.
There was a problem hiding this comment.
Pull request overview
This PR adds support for gRPC client-side and bidirectional streaming by enabling multiple JSON objects to be streamed as individual gRPC frames. The implementation uses io.Pipe for incremental delivery and automatically detects streaming methods via the proto schema's MethodDescriptor.IsStreamingClient().
Changes:
- Modified
setupGRPCto detect and return whether a method is client-streaming - Added
streamGRPCRequestfunction to handle streaming multiple JSON objects as separate gRPC frames - Updated request processing logic to handle client-streaming vs unary/server-streaming differently
- Added comprehensive test coverage for streaming scenarios
- Updated documentation to reflect streaming support
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/fetch/proto.go | Added streamGRPCRequest function and modified setupGRPC to detect client-streaming methods |
| internal/fetch/fetch.go | Updated request processing to handle client-streaming separately from unary calls |
| internal/fetch/proto_test.go | Added unit tests for streamGRPCRequest covering various input scenarios |
| integration/integration_test.go | Added integration tests for client-streaming gRPC with multiple test cases |
| docs/grpc.md | Updated documentation to describe client and bidirectional streaming support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream multiple JSON objects as individual gRPC frames using io.Pipe for incremental delivery. Detection is automatic via the proto schema's MethodDescriptor.IsStreamingClient(), requiring no new CLI flags.